This revision was automatically updated to reflect the committed changes.
Closed by commit rL362004: [WebAssembly] Support VPtr sanitizer for Emscripten
(authored by tlively, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
aheejin added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
aheejin wrote:
> quantum wrote:
> > aheejin wrote:
> > > quantum wrote:
> > > > aheejin wrote:
aheejin added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
quantum wrote:
> aheejin wrote:
> > quantum wrote:
> > > aheejin wrote:
> > > > Does this mean
quantum marked 2 inline comments as done.
quantum added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
aheejin wrote:
> quantum wrote:
> > aheejin wrote:
>
quantum updated this revision to Diff 201803.
quantum marked an inline comment as done.
quantum added a comment.
Add a test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62559/new/
https://reviews.llvm.org/D62559
Files:
clang/lib/Driver/ToolChai
aheejin added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
quantum wrote:
> aheejin wrote:
> > Does this mean we only support `Vptr` among sanitizers [[
quantum marked 2 inline comments as done.
quantum added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
aheejin wrote:
> Does this mean we only support `Vptr
tlively added a comment.
Please add a test!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62559/new/
https://reviews.llvm.org/D62559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
aheejin added inline comments.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+ if (getTriple().isOSEmscripten()) {
+Res |= SanitizerKind::Vptr;
+ }
Does this mean we only support `Vptr` among sanitizers [[
https://github.com/llvm/llvm-project
quantum created this revision.
quantum added reviewers: tlively, aheejin.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100,
dschuff.
Herald added a project: clang.
After https://github.com/emscripten-core/emscripten/pull/8651, Emscripten
supports the full UBSan runtime. Th
10 matches
Mail list logo