[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

2019-05-28 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361834: [clang-tidy] Fix description for misc-definitions-in-headers. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

2019-05-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 201670. hokein marked an inline comment as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62524/new/ https://reviews.llvm.org/D62524 Files: clang-tools-extra/clan

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

2019-05-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp:133 +<< IsFullSpec << FD; +diag(FD->getLocation(), /*FixDescription=*/"make

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

2019-05-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62524 Files: clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tools-extr