uabelho added inline comments.
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+// FIXME: this should only be set on CK_CurrentParameter.
+Signal.ContainsActiveParameter = true;
+ }
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > uabelho
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+// FIXME: this should only be set on CK_CurrentParameter.
+Signal.ContainsActiveParameter = true;
+ }
il
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+// FIXME: this should only be set on CK_CurrentParameter.
+Signal.ContainsActiveParameter = true;
+ }
ua
uabelho added inline comments.
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+// FIXME: this should only be set on CK_CurrentParameter.
+Signal.ContainsActiveParameter = true;
+ }
Hi!
gcc (7.4) warns on this code:
```
error: parameter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362481: [clangd] Support offsets for parameters in
signatureHelp (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
h
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
nice, looks good
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62476/new/
https://reviews.llvm.org/D62476
___
ilya-biryukov updated this revision to Diff 201493.
ilya-biryukov added a comment.
- Fix parsing of a client capability, add a test for a capability
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62476/new/
https://reviews.llvm.org/D62476
Files:
ilya-biryukov updated this revision to Diff 201487.
ilya-biryukov added a comment.
- Fix compilation when assertions are enabled
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62476/new/
https://reviews.llvm.org/D62476
Files:
clang-tools-extra/cl
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Added to LSP in version 3.14
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D62476
Files:
clang-tools-ex
