[PATCH] D62471: [clangd] SymbolCollector support for relations

This revision was automatically updated to reflect the committed changes. Closed by commit rL362467: [clangd] SymbolCollector support for relations (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge added a comment. In D62471#1527085 , @kadircet wrote: > LGTM, thanks! Thanks for the reviews so far! > I suppose there are only two patches left now? > > - Exposing relations in `SymbolIndex`. > - Implementing children resolution using that info

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! I suppose there are only two patches left now? - Exposing relations in `SymbolIndex`. - Implementing children resolution using that information. Repository: rG LLVM Githu

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge updated this revision to Diff 202646. nridge marked 5 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62471/new/ https://reviews.llvm.org/D62471 Files: clang

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + nridge wrote: > kadircet wrote: > > why do we want to process these relations for references? > The `RelationBaseOf` i

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + kadircet wrote: > why do we want to process these relations for references? The `RelationBaseOf` is not present in the `

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge updated this revision to Diff 202371. nridge marked 11 inline comments as done. nridge added a comment. Addressed most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62471/new/ https://reviews.llvm.org/D62471 Files: clang-t

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet added a comment. Can you also add some tests ? we have some tests in `unittests/SymbolCollectorTests.cpp` Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + why do we want to process these

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The only relation currently collected is RelationBaseOf, because this is all we need for type hierarchy subtypes. Addit