This revision was automatically updated to reflect the committed changes.
Closed by commit rL366059: [OpenCL][PR41727] Prevent ICE on global dtors
(authored by stulova, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
rjmccall added a comment.
If you're interested in working on this, great. I actually think there's zero
reason to emit a non-null argument here on any target unless we're going to use
the destructor as the function pointer — but we can do that on every Itanium
target, so we should. So where w
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Current patch LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62413/new/
https://reviews.llvm.org/D62413
___
cfe-commits mailing
Anastasia updated this revision to Diff 209463.
Anastasia added a comment.
Generate NULL for pointer param of __cxa_atexit on mismatching addr spaces
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62413/new/
https://reviews.llvm.org/D62413
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGe
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
r
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
Anastasia wrote:
> rjmccall wrote:
> > rjmccal
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
r
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
rjmccall wrote:
> Anastasia wrote:
> > rjmccal
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: lib/CodeGen/TargetInfo.h:274
+return LangAS::Default;
+ }
+
rjmccall wrote:
> This target hook should just return the address space of the `__cxa_atexit`
> argument, no
Anastasia updated this revision to Diff 209012.
Anastasia added a comment.
Changed API for target hook.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62413/new/
https://reviews.llvm.org/D62413
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/ItaniumCXXAB
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.h:274
+return LangAS::Default;
+ }
+
This target hook should just return the address space of the `__cxa_atexit`
argument, not to claim anything specific about the relation between that
add
Anastasia updated this revision to Diff 207574.
Anastasia added a comment.
Added a target hook to query address spaces with the largest pointer width.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62413/new/
https://reviews.llvm.org/D62413
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeG
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
Anastasia wrote:
> rjmccall wrote:
> > Anastas
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
r
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
Anastasia wrote:
> rjmccall wrote:
> > Should
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
r
Anastasia updated this revision to Diff 202708.
Anastasia added a comment.
- Guard OpenCL specific IR generation under OpenCL lang mode
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62413/new/
https://reviews.llvm.org/D62413
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CodeGenModul
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:132
+ Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast(
+ CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy);
Should this code be conditional to OpenCL? An
Anastasia created this revision.
Anastasia added a reviewer: rjmccall.
Herald added subscribers: ebevhan, yaxunl.
Preserve address spaces of global objects while generating 'atexit' stub.
https://reviews.llvm.org/D62413
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CodeGenModule.cpp
lib/Co
19 matches
Mail list logo
