[PATCH] D62372: [clangd] Limit the size of synthesized fix message

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361625: [clangd] Limit the size of synthesized fix message (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62372?vs=201179&id=201181#toc Repository: rCTE

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

2019-05-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 201179. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address comments, simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62372/new/ https://reviews.llvm.org/D62372

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

2019-05-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:449 + + size_t FirstNewline = R.find('\n'); + if (FirstNewline != llvm::StringRef::npos)

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

2019-05-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. A temporary workaround until we figure out a better way to present fixes. Repository: rG LLVM Github Monorepo https://reviews.llv