[PATCH] D62232: [Clang][Driver] recheck for nullptr

2019-05-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. According to the coverage report we don't have any coverage of TC == null at all - not sure if its (a) possible to add tests or (b) if we can ever have a non-null TC - so should we just assert? http://lab.llvm.org:8080/coverage/coverage-reports/clang/coverage/Users/buil

[PATCH] D62232: [Clang][Driver] recheck for nullptr

2019-05-21 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, sfantao. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No. 47". Looks like TC is checked for nullptr once, but not the seco