Re: [PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

2019-05-23 Thread Yitzhak Mandelbaum via cfe-commits
Fixed in https://reviews.llvm.org/D62320 On Thu, May 23, 2019 at 10:44 AM Sam Clegg via Phabricator < revi...@reviews.llvm.org> wrote: > sbc100 added a comment. > > I think this build broke the `-DLLVM_BUILD_LLVM_DYLIB=ON > -DLLVM_LINK_LLVM_DYLIB=ON` build. e.g > https://ci.chromium.org/p/wasm/bu

[PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

2019-05-23 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. I think this build broke the `-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` build. e.g https://ci.chromium.org/p/wasm/builders/ci/linux/6457 FAILED: tools/clang/unittests/Tooling/ToolingTests : && /b/swarming/w/ir/cache/builder/src/src/work/v8/v8/third_part

[PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

2019-05-21 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361285: [LibTooling] Address post-commit feedback for r361152 (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D62201?vs=200514&id=200559#toc Repository: rC Cla