[PATCH] D62065: Move dump method implementations to their respective class files

2019-05-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/Comment.cpp:378-380 +LLVM_DUMP_METHOD void Comment::dump() const { + dump(llvm::errs(), nullptr, nullptr); +} If we're moving things around, is there a reason we should keep this in a source file as oppos

[PATCH] D62065: Move dump method implementations to their respective class files

2019-05-17 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no need to group them together. Repository: rC Clang https://reviews.llvm.org/D62065 Files: lib/AST/ASTDumper.cpp lib/AST/Comment.cpp