This revision was automatically updated to reflect the committed changes.
mgorny marked an inline comment as done.
Closed by commit rL361931: [libunwind] [test] Fix inferring source paths
(authored by mgorny, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
C
mgorny marked 2 inline comments as done.
mgorny added inline comments.
Comment at: libunwind/test/libunwind/test/config.py:27
+self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root')
+or os.path.join(self.libunwind_src_root, '../libcxx'))
--
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: libunwind/test/libunwind/test/config.py:27
+self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root')
+or os.path.join(self.libunwind_
mgorny added a comment.
Ping. Could somebody review this, please? It's blocking NetBSD buildbot for
quite some time already.
Repository:
rUNW libunwind
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62005/new/
https://reviews.llvm.org/D62005
___
krytarowski resigned from this revision.
krytarowski added a comment.
Herald added a subscriber: krytarowski.
It is probably fine.. but I will defer review to lit/libc++ maintainers.
Repository:
rUNW libunwind
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62005/new/
https://reviews.l
mgorny added a comment.
Ping.
Repository:
rUNW libunwind
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62005/new/
https://reviews.llvm.org/D62005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
mgorny created this revision.
mgorny added reviewers: jroelofs, krytarowski.
Herald added subscribers: libcxx-commits, ldionne, christof.
Fix two issues that caused libcxx source path not to be inferred
correctly when not specified explicitly:
1. get_lit_conf() uses default value only if the lit
