[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360802: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D61957?vs=199640&id=199666#toc Repository

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

2019-05-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m:208 + } +} Can you add tests for `objc_alloc`, `objc_allocWithZone` and `obj

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

2019-05-15 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: ahatanak, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Any of these methods can be overridden, so we always need to conservatively `invoke` these calls. Repository: rC Clang htt