[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. @adalava You need to run both `check-llvm` and `check-clang`, but it was my fault that I hadn't done this before committing... Two clang tests failed (http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24521) It should have been fixed by rC361365

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Reordered the code a bit and committed for you... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing list cfe-comm

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL361355: [PPC64] Parse -elfv1 -elfv2 when specified on target triple (authored by MaskRay, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D61950?vs

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay accepted this revision. MaskRay added a comment. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing lis

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added a comment. In D61950#1504169 , @MaskRay wrote: > Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner > to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the majo

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the major version, e.g. `powerpc64-unknown-freebsd13.0` could mean ELFv2. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked 3 inline comments as done. adalava added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: -return PPCTargetMachine::PPC_ABI_ELFv1; +// if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 +

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava updated this revision to Diff 199633. adalava added a comment. - remove redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 Files: clang/lib/Basic/Targets/PPC.h llvm/include/llvm/A

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { MaskRay wrote: > MaskRay wrote: > > Have you researched how G

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: -return PPCTargetMachine::PPC_ABI_ELFv1; +// if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 +if (TT.getEnvironment() == llvm::Triple:

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { MaskRay wrote: > Have

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { Have you researched how GNU as chooses the default ABI? I think the change may break some Linux ppc64l