[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 360614 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D61858: Make `__is_base_of` more friendly with unions

rsmith accepted this revision. rsmith added a comment. Yeah, this seems to match the library wording. (I think it's short-sighted and over-fitting -- this is baking into the library specification that the language happens to not allow unions to have base classes today -- but this isn't the venu

[PATCH] D61858: Make `__is_base_of` more friendly with unions

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. I'm not a frontend expert, but this looks reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 _

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists added a comment. In D61858#1500270 , @ldionne wrote: > Shouldn't we also add unit tests for PR41843 in libc++? Yes. But I want to do that later. After this has landed (and probably wait a week for all the bots that are running trunk to updat

[PATCH] D61858: Make `__is_base_of` more friendly with unions

ldionne added a comment. Shouldn't we also add unit tests for PR41843 in libc++? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://reviews.llvm.org/D61858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists added a comment. Note: There are tabs in `clang/test/SemaCXX/type-traits.cpp` that I didn't remove because it would have cluttered up the diff. I can de-tabify the file when it is committed if people want. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61858/new/ https://rev

[PATCH] D61858: Make `__is_base_of` more friendly with unions

mclow.lists created this revision. mclow.lists added reviewers: rsmith, t.p.northover, EricWF, ldionne. mclow.lists added a project: clang. Herald added a subscriber: dexonsmith. Unions are never base classes, and never have base classes. It doesn't matter if they are complete or not. See http://l