[PATCH] D61790: [C++20] add Basic consteval specifier

rnk added inline comments. Comment at: cfe/trunk/include/clang/Sema/DeclSpec.h:366 // constexpr-specifier - unsigned Constexpr_specified : 1; + ConstexprSpecKind ConstexprSpecifier : 2; Please always use `unsigned` for bitfields to avoid sign extensions un

[PATCH] D61790: [C++20] add Basic consteval specifier

dyung added a comment. Hi, the test cxx2a-consteval.cpp that you added in this commit is failing on the PS4 Windows bot. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/9/steps/test/logs/stdio FAIL: Clang :: SemaCXX/cxx2a-consteval.cpp (13131 of 50204

[PATCH] D61790: [C++20] add Basic consteval specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL363362: [C++20] add Basic consteval specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203725. Tyker marked 5 inline comments as done. Tyker added a comment. fixed requested changes. also adapted lldb to AST change. I will commit this when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D

[PATCH] D61790: [C++20] add Basic consteval specifier

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only minor comments remain (other than the `-Wc++17-compat` warning). In the interest of incremental progress, let's leave the `-Wc++17-compat` warning for a later patch; feel free to commit t

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203551. Tyker marked 9 inline comments as done. Tyker added a comment. fixed requested changes except some i commented upon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 Files: clang/include/clang/AST/Dec

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2491 + if (DS.hasConstexprSpecifier() && DSC != DeclSpecContext::DSC_condition) { Diag(DS.getConstexprSpecLoc(), diag::err_typename_invalid_constexpr); DS.ClearConstexprSpec(); rsmi

[PATCH] D61790: [C++20] add Basic consteval specifier

rsmith added a comment. Thank you! Comment at: clang/include/clang/AST/DeclBase.h:1497 + +/// kind of Contexpr specifier as defined by ConstexprSpecKind. +uint64_t ConstexprKind : 2; "kind" -> "Kind" "Contexpr" -> "constexpr" Comment

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 201535. Tyker marked 13 inline comments as done. Tyker retitled this revision from "[C++20] add consteval specifier" to "[C++20] add Basic consteval specifier". Tyker edited the summary of this revision. Tyker added a comment. Herald added a subscriber: eraman.

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10471 + bool IsConstantContext = S.ExprEvalContexts.back().isConstantEvaluated(); + rsmith wrote: > Are the changes to this file really specific to `consteval` evaluation? They > look mo