This revision was automatically updated to reflect the committed changes.
Closed by commit rC360572: [ASTImporter] Separate unittest files (authored by
martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61786?vs=199225&id=199226#toc
Repository:
rC Clang
CHANGES SINC
martong marked 8 inline comments as done.
martong added a comment.
Thanks for the review Alexei!
Comment at: clang/unittests/AST/ASTImporterGenericRedeclTest.cpp:20
+
+// FIXME put these structs and the tests rely on them into their own separate
+// test file!
martong updated this revision to Diff 199225.
martong marked 2 inline comments as done.
martong added a comment.
- Address Alexei's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61786/new/
https://reviews.llvm.org/D61786
Files:
clang/un
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
I like this change! LGTM, just a few nits.
Comment at: clang/unittests/AST/ASTImporterGenericRedeclTest.cpp:20
+
+// FIXME put these structs and the tests rel
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs,
mgorny.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
Move generic redecl chain tests and visibi
