[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. In D61697#1543443 , @thakis wrote: > I reverted this in r363379 to unbreak check-lld on mac. I think the > > if config.enable_shared: > features.add("enable_shared") > > > bit belongs in clang/test/lit.cfg.py

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

thakis added a comment. I reverted this in r363379 to unbreak check-lld on mac. I think the if config.enable_shared: features.add("enable_shared") bit belongs in clang/test/lit.cfg.py, not in llvm/utils/lit/lit/llvm/config.py. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

phosek added a comment. This broke all our macOS builders: llvm-lit: /b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/k/recipe_cleanup/clangh7IvHV/llvm_build_dir/tools/lld/test/lit.site.cfg.py', traceback: Traceback (most recent

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363298: [lit] Disable test on darwin when building shared libs. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61697?vs=198720&id=204602#toc Repository: rL L

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, I see no way around it, we can't copy all of the shared libs. Maybe there's an alternative way to test this without copying the binary, but I don't have one in mind. Repos

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

sammccall resigned from this revision. sammccall edited reviewers, added: ilya-biryukov, hokein; removed: sammccall. sammccall added a comment. Sorry, I don't have any context on this (I just "blindly" fixed an asan error at one point). Adding original authors/reviewers of the test. Repository

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. @zturner, I only disabled this on Darwin because that's all I can test on right now. Please let me know if there's a better way to do this or if it should fire on different platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda created this revision. hintonda added a reviewer: zturner. Herald added subscribers: llvm-commits, delcypher. Herald added projects: clang, LLVM. This test fails to link shared libraries because tries to run a copied version of clang-check to see if the mock version of libcxx in the same