[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360039: [clangd] Expose whether no-compile completion was used. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61588?vs=198246&id=198251#toc Repository:

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the info. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.org/D61588 ___

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall added a comment. In D61588#1491728 , @kadircet wrote: > We already have `CodeCompletion::Origin` which is (at least should be)set to > `Identifier` in those cases. Is there a reason for not using it? I'd forgotten about that. A couple I can th

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet added a comment. We already have `CodeCompletion::Origin` which is (at least should be)set to `Identifier` in those cases. Is there a reason for not using it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.or

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Embedding clients want to experiment with showing such results in e.g. a different color. Repository: rCTE C