[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) jdenny wrote: > thakis wrote: > > This makes RewriteTests depend on clangTooling, and in follow-ups on > > clangFrontend and clangSeriali

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) thakis wrote: > This makes RewriteTests depend on clangTooling, and in follow-ups on > clangFrontend and clangSerialization. Rewrite used

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

thakis added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) This makes RewriteTests depend on clangTooling, and in follow-ups on clangFrontend and clangSerialization. Rewrite used to depend on basi

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

This revision was automatically updated to reflect the committed changes. Closed by commit rL365258: [Rewrite] Extend to further accept CharSourceRange (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. The comments help a lot. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-co

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny updated this revision to Diff 208247. jdenny added a comment. @jdoerfert Thanks for your reply. I added some comments to the tests. Let me know whether that's what you're looking for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 Fil

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdoerfert added a comment. Could you describe the unit tests a little, what is tested and why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny updated this revision to Diff 207301. jdenny added a comment. Rebased, fixed a comment, and applied a clang-format suggestion. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 Files: clang/include/clang/Rewrite/Core/Rewriter.h c

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: clang/unittests/Rewrite/RewriterTest.cpp:1 +//===- unittests/Rewrite/RewriteTest.cpp - RewriteBuffer tests ===// +// Oops. Need to change the description here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added a comment. Ping. This seems like a straight-forward extension to the Rewriter API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny created this revision. jdenny added reviewers: akyrtzi, Eugene.Zelenko, rsmith. Herald added subscribers: dexonsmith, mgorny. Herald added a project: clang. Some Rewrite functions are already overloaded to accept CharSourceRange, and this extends others in the same manner. I'm calling the