[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. > This allows for us to fall back from arch-specific to generic headers as > needed. The same can be true of libraries. Not all libraries contains > compiled code. `.so` files can also be linker scripts that reference other > libraries in which case they can be arch-

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. In D61452#1488789 , @sunfish wrote: > If "$sysroot/lib" ends up coming to mean "wasm32" because people come to > depend on that, then wasm64 may end up needing to be different in a > gratuitous way, which I'd like to avoid. > > I'

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. If "$sysroot/lib" ends up coming to mean "wasm32" because people come to depend on that, then wasm64 may end up needing to be different in a gratuitous way, which I'd like to avoid. I'd like to keep our sysroots tidy when we can. If some libraries are installed in `lib

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. Even in the case of wasm64 it might well be that somebody wants to build two different sysroots (as they would be arm and arm64 on linux). Even if we don't choose to ship a single arch sysroot for wasi somebody else might. This doesn't seem like it does any harm to me.

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. The value of supporting single-arch sysroots is unclear to me. It's always possible to have a sysroot with libraries for just one architecture installed, even with multi-arch paths. Is this just about compatibility with build scripts and tools which are hard-coded to "$

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. In D61452#1488330 , @sunfish wrote: > If libraries don't correctly install into multi-arch directories, can we fix > the libraries? We do this in the wasi-sdk repo to fix up the libc++ and > libc++abi libraries, for example. Sur

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. If libraries don't correctly install into multi-arch directories, can we fix the libraries? We do this in the wasi-sdk repo to fix up the libc++ and libc++abi libraries, for example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 updated this revision to Diff 197823. sbc100 added a comment. - update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61452/new/ https://reviews.llvm.org/D61452 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 updated this revision to Diff 197821. sbc100 added a comment. Herald added a subscriber: ormris. tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61452/new/ https://reviews.llvm.org/D61452 Files: clang/lib/Driver/ToolChains/WebAssembly

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. Even though the toolchain supports multiarch, we still want to be able to support single-arch sysroots. This also helps for the case where libraries do