[PATCH] D61408: Use primary template parameter names for variable template debug info

2019-05-02 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL359809: Use primary template parameter names for variable template debug info (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D61408: Use primary template parameter names for variable template debug info

2019-05-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D61408#1487978 , @dblaikie wrote: > Ah, nevermind - alias templates can't be partially specialized. No worries > then :) That, and I think alias templates can only be created for types? So I don't think we can get to this codepa

[PATCH] D61408: Use primary template parameter names for variable template debug info

2019-05-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D61408#1487030 , @dblaikie wrote: > Seems totally reasonable to me & it's what we do for other templates > (function and class), it seems. > > Might want to check alias templates too? Ah, nevermind - alias templates can't be

[PATCH] D61408: Use primary template parameter names for variable template debug info

2019-05-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems totally reasonable to me & it's what we do for other templates (function and class), it seems. Might want to check alias templates too? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D61408: Use primary template parameter names for variable template debug info

2019-05-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: JDevlieghere, aprantl, ormris, dblaikie. Herald added a project: clang. Fixes PR41677 Consider: template constexpr bool is_same_v = false; template constexpr bool is_same_v = true; template constexpr bool is_same_v; Before this change, whe