[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-03 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL359943: [clang-format] Fix bug in block comment reflow that joins * and / (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-03 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 198057. owenpan added a comment. Updated the test cases to make them precise and more varied. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 Files: clang/lib/Format/BreakableToken.

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-03 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 __

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 197720. owenpan added a comment. Updated the patch to cover all scenarios in which the bug might be triggered. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 Files: clang/lib/Forma

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan planned changes to this revision. owenpan added a comment. There are some corner cases this patch doesn't cover. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 ___ cf

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-01 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. @MyDeveloperDay In theory, any whitespace character other than a blank might trigger the bug, but in practice, we only need to handle the tab, IMO. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-05-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thanks for the patch, is this case only limited to * Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

2019-04-29 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: klimek, sammccall, MyDeveloperDay, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes PR41213 . Repository: rC Clang https://reviews.ll