[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rL359448: [libclang] Restore old clang_Cursor_isAnonymous behaviour (authored by yvvan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197038. JornVernee added a comment. Incremented minor version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee marked an inline comment as done. JornVernee added a comment. No worries! I'm already glad there's someone who picked up the review for this so quickly ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

yvvan added a comment. Thank you! Sorry that I forgot about the required minor version increment. I will run tests tomorrow and then I can commit it for you. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 55 --

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197019. JornVernee marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/li

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index: tools/libclang/CXT

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

yvvan added a comment. Could you please also upload diff with the full context? It's -U for git and quite similar for svn. Otherwise looks ok. Comment at: test/Index/print-type.c:70 // CHECK: TypeRef=struct Struct:16:8 [type=struct Struct] [typekind=Record] [isPOD=1] +//

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. @yvvan Hows that as a test? I'm pretty new at this, and it took a while to figure out how to run the tests. I used something like: `build\Release\bin\c-index-test.exe -test-print-type .\test\Index\print-type.c | ..\llvm\build\Release\bin\FileCheck .\test\Index\print

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 196988. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index: tools/libclang/CXT

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

yvvan added a comment. Now we know that somebody else also uses libclang :) I the mentioned change I only wanted to follow the same logic as in TypePrinter::printTag to cover more anonymity cases. Adding the old one as an extra function seems totally fine to me. Can you please add some tests f

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. Also, I don't have commit access, so I would need some help with that if this gets accepted :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 ___

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee created this revision. JornVernee added reviewers: yvvan, nik, rsmith. JornVernee added a project: clang. Herald added a subscriber: arphaman. https://reviews.llvm.org/D54996 Changed the behaviour of clang_Cursor_isAnonymous, but there is no alternative available to get the old behavi