This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE359801: Fixed: Duck-typing in
readability-redundant-smartptr-get didn't catch MSVC STL… (authored by
fgross, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61209?vs=196960&id=1978
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a commenting nit.
Comment at:
clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp:46
+ // Make sure we are not missing th
fgross updated this revision to Diff 196960.
fgross added a comment.
Fixed test file format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61209/new/
https://reviews.llvm.org/D61209
Files:
clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
clang-tools-extra/test/
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/readability-redundant-smartptr-get-msvc.cpp:37
+void Positive() {
+
+ std::unique_ptr* up;
Unnecessary empty line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/readability-redundant-smartptr-get-msvc.cpp:96
+}
\ No newline at end of file
Please add new line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
fgross updated this revision to Diff 196911.
fgross added a comment.
Fixed format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61209/new/
https://reviews.llvm.org/D61209
Files:
clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp
clang-tools-extra/test/clang-tidy
lebedev.ri added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp:60
// Catch '!ptr.get()'
- const auto CallToGetAsBool = ignoringParenImpCasts(callToGet(recordDecl(
- QuacksLikeASmartptr, has(cxxConversionDecl(returns(
