This revision was automatically updated to reflect the committed changes.
kadircet marked 2 inline comments as done.
Closed by commit rL359874: [clangd] Also perform merging for symbol definitions
(authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/XRefs.cpp:350
if (R.Definition) { // from AST
+// In case of generated files we prefer to omit the definition in
kadircet updated this revision to Diff 197725.
kadircet added a comment.
- Update diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61126/new/
https://reviews.llvm.org/D61126
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/
kadircet updated this revision to Diff 196654.
kadircet added a comment.
- Get rid of debug comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61126/new/
https://reviews.llvm.org/D61126
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
clangd currently prefers declarations from codegen files. This patch
implements that behavior for definition locat
