[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Szelethus added a comment. I mean, better late then never, but LGTM :^) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359531: [analyzer] Treat functions without run-time branches as "small". (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61051?vs=197248&id=197253#toc Reposit

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 197248. NoQ added a comment. Crystallize the `isHuge()` function and document more stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h clang/include/clang/StaticA

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added a comment. In D61051#1481976 , @Charusso wrote: > Great patch! There is only a design problem: > You have negated every `isSmall()` condition looks like you could write > `isLarge()` instead but there is no connection between these functions. >

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Great patch! There is only a design problem: You have negated every `isSmall()` condition looks like you could write `isLarge()` instead but there is no connection between these functions.

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 196733. NoQ marked 4 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h clang/include/clang/StaticAnalyzer/Core/PathS

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4684 + if (size() <= 3) +return true; + Szelethus wrote: > What are the cases for the size being 2 or 1? Empty function? Is a size of 1 > even possible? Can we enforce something here with ass

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ marked 4 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:723 + /// should always inline simply because it's small enough. + bool isSmall(AnalysisDeclContext *ADC) const; + S

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Szelethus added a comment. Nice! I have no objections (other than the nits) to this! Ill take a second look later, because I really need to play around with `CFG` a bit to give a definitive LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, eraman. Herald added a project: clang. Currently we always inline fun