[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

This revision was automatically updated to reflect the committed changes. Closed by commit rL360044: Fix compilation warnings when compiling with GCC 7.3 (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61046?vs=196655&id=198265#toc Repository: rL LLVM

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked an inline comment as done. aganea added a comment. In D61046#1486850 , @rnk wrote: > The only remaining change I find questionable is the R600 backend change creduce'd and reported here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63477#c

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm The only remaining change I find questionable is the R600 backend change, but on the whole I think it's fine and you don't need to wait for more review. Better to fix the warnings and people w

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added a comment. Ping! Is this good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196655. aganea marked 3 inline comments as done. aganea added a comment. Please let me know if other changes are needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTI

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set_s

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } aganea wrote: > rnk wrote: > > nikic wrote: > > > shafik wrote: > > > > aganea wrote: > > > > > Fixes > > > > > ``` > > > > > [2097/2979] Building CXX object

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } rnk wrote: > nikic wrote: > > shafik wrote: > > > aganea wrote: > > > > Fixes > > > > ``` > > > > [2097/2979] Build

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } nikic wrote: > shafik wrote: > > aganea wrote: > > > Fixes > > > ``` > > > [2097/2979] Building CXX object > > > tools/clang/unittests/Tooling/CMakeFiles/Tool

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__ >=

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196505. aganea marked 7 inline comments as done. aganea added a comment. Adressed some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

nikic added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } shafik wrote: > aganea wrote: > > Fixes > > ``` > > [2097/2979] Building CXX object > > tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

shafik added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } aganea wrote: > Fixes > ``` > [2097/2979] Building CXX object > tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest.cpp.o > /mnt/f/svn/cla

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

nikic added inline comments. Comment at: llvm/trunk/unittests/IR/ConstantRangeTest.cpp:398-401 +#if defined(__GNUC__) && __GNUC__ >= 7 +// Silence warning: variable 'HaveInterrupt3' set but not used +(void)&HaveInterrupt3; +#endif tstellar wrote:

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

MaskRay added inline comments. Comment at: llvm/trunk/include/llvm/BinaryFormat/ELF.h:878 enum : unsigned { + SHF_NONE, + `SHF_NONE` is not defined in `/usr/binclude/elf.h`. `(unsigned)SHF_ALLOC` is probably better. CHANGES SINCE LAST ACTION https://review

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp clang/trunk/unittests/Tooling/LookupTest.cpp lld/trunk/ELF/LinkerScript.cpp llvm/trunk/includ

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 5 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } Fixes ``` [2097/2979] Building CXX object tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest.cpp

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea created this revision. aganea added reviewers: spatel, rnk, nikic, chandlerc, MaskRay, martong, ioeric. aganea added projects: LLVM, clang, lld. Herald added subscribers: rnkovacs, arichardson, mgorny, nhaehnle, jvesely, mehdi_amini, emaste, arsenm. Herald added a reviewer: espindola. Heral