[PATCH] D60990: [Driver] Support priority for multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rC359359: [Driver] Support priority for multilibs (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60990?vs=196905&id=196933#toc Repository: rC Clang CHANGES SIN

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196905. phosek marked an inline comment as done. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp

[PATCH] D60990: [Driver] Support priority for multilibs

phosek added a comment. In D60990#1475116 , @lebedev.ri wrote: > Can this have test coverage? Done, I've added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990

[PATCH] D60990: [Driver] Support priority for multilibs

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Multilib.h:81 + /// Returns the multilib priority. + int priority() const { return Priority; } Say explic

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196331. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp Index: clang/lib/Driver/Multilib

Re: [PATCH] D60990: [Driver] Support priority for multilibs

LGTM On Mon, Apr 22, 2019 at 8:34 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek created this revision. > phosek added reviewers: jroelofs, bkramer. > Herald added subscribers: cfe-commits, mgrang. > Herald added a project: clang. > > When more than one multilib flag ma

[PATCH] D60990: [Driver] Support priority for multilibs

lebedev.ri added a comment. Can this have test coverage? Comment at: clang/lib/Driver/Multilib.cpp:22 #include +#include #include Doesn't seem to be used? Comment at: clang/lib/Driver/Multilib.cpp:271 + // Sort multilibs by priority and

[PATCH] D60990: [Driver] Support priority for multilibs

phosek created this revision. phosek added reviewers: jroelofs, bkramer. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. When more than one multilib flag matches, try to select the best possible match based on priority. When two different multilibs with the same same