[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358709: [OpenMP] Add checks for requires and target directives. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D60875?vs=195793&id=195803#toc Repository: rC C

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 ___ cfe-commits ma

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195793. gtbercea added a comment. - Lower case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/O

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with '%0' clause">; +def note_omp_requires_encountered_target : Note <

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195771. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/OpenMP/r

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195770. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:4207 +DSAStack->hasRequiresDeclWithClause()) && + !CurContext->isDependentContext()) { +// Register target to DSA Stack. ABataev wrote: > Better to check for the dependent context

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195768. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKi

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195762. gtbercea added a comment. Fix test, Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/Ope

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with %0 clause">; +def note_omp_requires_encountered_target : Note < E

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong. Herald added a project: clang. The requires directive containing target related clauses must appear before any target region in the compil