[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D60872#1473205 , @rsmith wrote: > Hmm. So there are a few different situations where we might meet an unknown > attribute (I'm sure I missed some): > > 1. The attribute had

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

rsmith added a comment. Hmm. So there are a few different situations where we might meet an unknown attribute (I'm sure I missed some): 1. The attribute had a typo in it (eg: [[clagn::fallthrough]]). 2. The attribute has semantic effects (ignoring it is incorrect and will -- at best -- not comp

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems pretty good to me - if you'd like to wait for more/other feedback from @rsmith or the like, that's OK too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman updated this revision to Diff 195790. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://reviews.llvm.org/D60872 Files: include/clang/Basic/Dia

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman marked 7 inline comments as done. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > dblaikie wrote: > > Not su

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

dblaikie added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > Not sure how it's done elsewhere - but I'd sink these #defines down to > immed