[PATCH] D60663: Time profiler: small fixes and optimizations

2019-07-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", anton-afanasyev wrote: > sammccall wrote: > > I know this is late, but... this shows up in the help for

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-07-24 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", sammccall wrote: > I know this is late, but... t

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-07-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", I know this is late, but... this shows up in the help for any tool that links in libSupport, many of wh

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-15 Thread Anton Afanasyev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358448: Time profiler: small fixes and optimizations (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D60663?vs=195069

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-15 Thread Aras Pranckevičius via Phabricator via cfe-commits
aras-p added a comment. > So i can't and won't claim any legal knowledge, but it maybe would be good > for him to at least comment here, that he is ok with this? Yes, absolutely fine. The only reason why some files started with the old license blurb is because I started the branch before licens

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-15 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Ok, LG, thank you! Comment at: llvm/lib/Support/TimeProfiler.cpp:30 +cl::desc( +"Minimum time granularity (in microsecons) traced by time profiler"), +

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-15 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675 > > This is the first part of time tracing system, I have splitted them cause > > this part

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-14 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev updated this revision to Diff 195069. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files: clang/tools/driver/cc1_main.cpp llvm/include/llvm/Su

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-14 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev updated this revision to Diff 195068. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files: clan

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-14 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev marked 7 inline comments as done. anton-afanasyev added a subscriber: aras-p. anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Looks good ignoring the json bits. Re license: > https://reviews.llvm.org/D58675 > This is the first part of time tracing system, I have splitted them cause > this part is mostly written by Aras Pranckevicius except of several minor > fixes concerning formatting.

[PATCH] D60663: Time profiler: small fixes and optimizations

2019-04-14 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev created this revision. anton-afanasyev added a reviewer: lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, mgrang, hiraditya. Herald added projects: clang, LLVM. Fixes from Roman's review here: https://reviews.llvm.org/D58675#1465336 Repository: rG LLVM Github Mo