ldionne added a comment.
Reverted in r358437 because of unforeseen CI failures. The failures I was
expecting are in libc++, not in compiler-rt. I'll investigate locally and
re-apply.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60626/new/
https://reviews.llvm.o
ldionne added a comment.
Just as a note to someone that might get here through CI failures: I expect
this will break back-deployment CIs for libc++ that use recent Clangs (because
the XFAILs in libc++ won't be correct anymore). I have a patch ready to address
that but I want to see exactly how
This revision was automatically updated to reflect the committed changes.
Closed by commit rL358409: [clang] Aligned allocation is actually supported in
macosx 10.13 (authored by ldionne, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commi
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60626/new/
https://reviews.llvm.org/D60626
___
ldionne created this revision.
ldionne added a reviewer: ahatanak.
Herald added subscribers: cfe-commits, dexonsmith, jkorous.
Herald added a project: clang.
In r350649, I changed aligned allocation from being available starting
in macosx10.13 to macosx10.14. However, aligned allocation is indeed
