[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363360: [clang] Don't segfault on incorrect using directive (PR41400) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

Tyker added a subscriber: jkooker. Tyker added a comment. @jkooker i don't think it is possible for `ASTContext::getDependentNameType` to deal with `NSS = nullptr` except by reporting the error. we probably don't want to just report the error because the error could have been handled before invo

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

jkorous added a comment. I can't really comment on correctness of your fix but had been willing to do the work I'd suggest making `ASTContext::getDependentNameType` and `DependentNameType::DependentNameType` interface more robust. With current master (95c18c7beec

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

riccibruno resigned from this revision. riccibruno added a comment. In D60523#1473867 , @riccibruno wrote: > I will take a look at this tomorrow, I know that it is annoying to get no > feedback! Sorry, I don't think I can judge whether this is the corre

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

riccibruno added a reviewer: riccibruno. riccibruno added a comment. I will take a look at this tomorrow, I know that it is annoying to get no feedback! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60523/new/ https://reviews.llvm.org/D60523 _