rjmccall added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9232
+if (IsFloat && Size > FLen)
+ return false;
+// Can't be eligible if an integer type was already found (only fp+int or
Is this the only consideration for floating-poin
asb added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:9223
+
+ bool IsInt = Ty->isIntegralOrEnumerationType();
+ bool IsFloat = Ty->isRealFloatingType();
rjmccall wrote:
> Should this include pointers? Pointers are often interchangeably with
> int
asb updated this revision to Diff 198797.
asb marked 3 inline comments as done.
asb added a comment.
Update:
- Expanded and improved tests
- Set ABI defines
- Remove errant TODO
- Use alignTo
Still to do:
- Review and test bitfield handling (which is likely incomplete)
CHANGES SINCE LAST ACTI
rjmccall added inline comments.
Comment at: lib/Basic/Targets/RISCV.h:102
// TODO: support lp64f and lp64d ABIs.
-if (Name == "lp64") {
+if (Name == "lp64" || Name == "lp64f" || Name == "lp64d") {
ABI = Name;
You can remove the TODO here, assu
asb created this revision.
asb added a reviewer: rjmccall.
Herald added subscribers: benna, psnobl, jocewei, PkmX, rkruppe, the_o,
brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar.
Herald added a project
