rnk added a comment.
> This is blocked on fixing PR41431.
I reviewed the code, but timed out while trying to understand PR41431. Maybe
ping @rsmith about it again?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60418/new/
https://reviews.llvm.org/D60418
_
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2355
+ // XXX so comment is handled before pp directive is done, so no linetable
+ // entry yet when the handler runs.
if (ParsingPreprocessorDirective || CurPtr == Buf
thakis created this revision.
thakis added reviewers: rnk, rsmith.
This fixes one TODO and one FIXME in ConvertBackendLocation() about not copying
llvm::MemoryBuffers when converting from from llvm::SMDiagnostics to
clang::Diagnostics.
The basic idea is to use
`SourceManager::createFileID(clan
