[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

This revision was automatically updated to reflect the committed changes. Closed by commit rL357877: [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413 (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan requested review of this revision. owenpan added a comment. Updated the diff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 ___ cfe-commits mailing list cfe-commits@

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan updated this revision to Diff 194072. This revision is now accepted and ready to land. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/Form

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. In D60374#1457705 , @owenpan wrote: > In D60374#1457693 , @MyDeveloperDay > wrote: > > > LGTM , if you also think the test will help show the use case then please > > add it, otherw

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457693 , @MyDeveloperDay wrote: > LGTM , if you also think the test will help show the use case then please add > it, otherwise this revision notes might be information enough Thanks! I just got the alternative patch

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan planned changes to this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:968 if (Current.is(tok::r_paren) && State.Stack.size() > 1 && - (!Current.Next || Current.Next->isOneOf(tok::semi, tok::l_brace))) + (!Curre

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough Repository: rC Clang CHANGES SIN

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457639 , @MyDeveloperDay wrote: > maybe add the following as a test because I think it shows the inconsistency > > void Foo::bar( // some comment > ) {} > > void Foo::bar( // some comment > ) const {} > I ha

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457638 , @klimek wrote: > The previous behavior looks intentional, and much more regular. I'd be > curious why you think the proposed behavior is more readable. I see the bug in the inconsistency for the code below:

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. maybe add the following as a test because I think it shows the inconsistency void Foo::bar( // some comment ) {} void Foo::bar( // some comment ) const {} Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https:/

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

klimek added a comment. The previous behavior looks intentional, and much more regular. I'd be curious why you think the proposed behavior is more readable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 _

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:968 if (Current.is(tok::r_paren) && State.Stack.size() > 1 && - (!Current.Next || Current.Next->isOneOf(tok::semi, tok::l_brace))) + (!Current.Next || Current.Next->isOneOf(to

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, sammccall, klimek, krasimir, djasper. owenpan added a project: clang. Herald added a subscriber: cfe-commits. See https://bugs.llvm.org/show_bug.cgi?id=41413 Repository: rC Clang https://reviews.llvm.org/D60374 Files: