[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

rnk added a comment. +@rsmith for the PresumedLoc change From glancing on the PresumedLoc computation code, I think this bool might be the way to go. You could make it a bit more "free" by stealing a bit from the column, if we're concerned about size. FYI, I'm off to EuroLLVM after this and re

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. In D60283#1456497 , @thakis wrote: > See > http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 > for a "is same file" example. I'm not sure adding a bool to PresumedLoc is > worth it for this. Yea

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. I'll try profiling several solution on a large unity/jumbo file and get back with some results. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cf

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

thakis added a comment. See http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 for a "is same file" example. I'm not sure adding a bool to PresumedLoc is worth it for this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 193886. aganea marked 2 inline comments as done. aganea edited the summary of this revision. aganea added a comment. I made a more elegant change, where no additional lookups or string compares are required. I noted btw that clang /E does not generate `#line`

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:429-430 + const FileEntry *fileEntry = SM.getFileEntryForID(foundIdFromLoc); + if (!fileEntry || fileEntry->getName().empty() || + fileEntry->getName().equals(FileName)) { +CSKind = computeChecksum(foun

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea created this revision. aganea added reviewers: rnk, scott.linder, uabelho, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling from an already preprocessed CPP, the checksums generated in the debug info would be those of the (input) preprocessed C