[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

This revision was automatically updated to reflect the committed changes. Closed by commit rC361296: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP (authored by aganea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ ht

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-comm

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. Ping! Any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 199659. aganea marked 3 inline comments as done. aganea added a comment. In D60283#1503256 , @probinson wrote: > Minor stuff. This solution is surprisingly simple, the main question being > (and I don't have an answer

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson added a comment. Minor stuff. This solution is surprisingly simple, the main question being (and I don't have an answer) whether increasing the size of PresumedLoc is okay. Comment at: lib/Basic/SourceManager.cpp:1460 +FID = FileID::get(0); // contents of fi

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 199599. aganea marked an inline comment as done. aganea added a comment. Updated again with a different solution. We can't just act on `Entry.getFile().hasLineDirectives()` because a directive such as `#line 100` simply overrides the `__LINE__`, not `__FILE__

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

thakis added a comment. (Just for the record, I'm happy with whatever y'all end up with.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list cfe-comm

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson added a comment. In D60283#1480546 , @aganea wrote: > Thanks Paul, your solution is even better. I'll apply rL11 > locally - if everything's fine, do you > mind if I re-land it again? I suggest you do *

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. Thanks Paul, your solution is even better. I'll apply rL11 locally - if everything's fine, do you mind if I re-land it again? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://review

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson added a comment. I had tried to do this in r11 but some bots complained, so I reverted it and then didn't follow through. Thanks for doing this! When I tried it, I took advantage of existing tracking of line directives at the file level, so there shouldn't be a need to add a Line

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

rnk added a comment. In D60283#1456497 , @thakis wrote: > See > http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 > for a "is same file" example. I'm not sure adding a bool to PresumedLoc is > worth it for this. @thaki

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 196321. aganea retitled this revision from "[clang-cl] Don't emit checksums when compiling a preprocessed CPP" to "[DebugInfo] Don't emit checksums when compiling a preprocessed CPP". aganea added a comment. Herald added a project: LLVM. Herald added a subscri