This revision was automatically updated to reflect the committed changes.
Closed by commit rC358378: [Lookup] Invisible decls should not be ambiguous
when renaming. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60257?vs=194841&id=195103#toc
Repository:
ioeric updated this revision to Diff 194841.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Add test comment.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60257/new/
https://reviews.llvm.org/D60257
Files:
include/clang/Tooling/Core/Lookup.
ioeric added inline comments.
Comment at: unittests/Tooling/LookupTest.cpp:215
+
+ // Potentially ambiguous symbols that are not visible at reference location
+ // are not considered ambiguous.
hokein wrote:
> The test seems hard to understand what it actually
hokein added inline comments.
Comment at: unittests/Tooling/LookupTest.cpp:215
+
+ // Potentially ambiguous symbols that are not visible at reference location
+ // are not considered ambiguous.
The test seems hard to understand what it actually does, could you
ioeric created this revision.
ioeric added a reviewer: hokein.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
For example, a renamed type in a header file can conflict with declaration in
a random file that includes the header, but we should not consider the decl
ambiguous
