This revision was automatically updated to reflect the committed changes.
Closed by commit rL357476: gn build: Add build files for non-framework xpc
clangd bits (authored by nico, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60124?vs=193264&id=193290#toc
Repository:
rL
thakis marked 2 inline comments as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17
+ configs += [ "//llvm/utils/gn/build:clang_code" ]
+ deps = [
+"//clang-tools-extra/clangd",
mbonadei wrote:
mbonadei accepted this revision.
mbonadei added a comment.
This revision is now accepted and ready to land.
LGTM, just a couple of comments.
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17
+ configs += [ "//llvm/utils/gn/build:clang_code" ]
+ deps
thakis created this revision.
thakis added a reviewer: mbonadei.
Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov, mgorny.
Herald added a project: LLVM.
With this, check-clang-tools unit tests are complete, but the lit tests still
don't run the one