[PATCH] D60069: Declare std::tuple_element as struct instead of class

This revision was automatically updated to reflect the committed changes. Closed by commit rL357411: [libc++] Declare std::tuple_element as struct instead of class (authored by ldionne, committed by ). Herald added subscribers: llvm-commits, christof. Herald added a project: LLVM. Changed prior t

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie added a comment. In D60069#1449979 , @mclow.lists wrote: > I'm less enthusiastic about this change than the one for PR39871, because > there we were being inconsistent with ourselves. > However, my lack of enthusiasm is no reason not to land thi

[PATCH] D60069: Declare std::tuple_element as struct instead of class

mclow.lists accepted this revision. mclow.lists added a comment. I'm less enthusiastic about this change than the one for PR39871, because there we were being inconsistent with ourselves. However, my lack of enthusiasm is no reason not to land this. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie updated this revision to Diff 193106. jdoerrie added a comment. Remove redundant `public:` access controls CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60069/new/ https://reviews.llvm.org/D60069 Files: include/__tuple include/array include/span include/tuple include

[PATCH] D60069: Declare std::tuple_element as struct instead of class

mclow.lists added a comment. In D60069#1449937 , @jdoerrie wrote: > Right, there shouldn't be any inheritance. Some of the `public:` access > specifications are now redundant, though. And I think that you should get rid of them. Repository: rCXX lib

[PATCH] D60069: Declare std::tuple_element as struct instead of class

ldionne added a comment. In D60069#1449937 , @jdoerrie wrote: > Right, there shouldn't be any inheritance. Some of the `public:` access > specifications are now redundant, though. Can you please fix those? Repository: rCXX libc++ CHANGES SINCE LAST

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie added a comment. In D60069#1449932 , @mclow.lists wrote: > In D60069#1449928 , @mclow.lists > wrote: > > > Did you check the places that inherit from `tuple_element`? The > > public/private bits change b

[PATCH] D60069: Declare std::tuple_element as struct instead of class

mclow.lists added a comment. In D60069#1449928 , @mclow.lists wrote: > Did you check the places that inherit from `tuple_element`? The > public/private bits change between class and struct. Never mind. I was thinking of something else; I don't think th

[PATCH] D60069: Declare std::tuple_element as struct instead of class

mclow.lists added a comment. Did you check the places that inherit from `tuple_element`? The public/private bits change between class and struct. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60069/new/ https://reviews.llvm.org/D60069

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie created this revision. jdoerrie added a reviewer: mclow.lists. Herald added subscribers: libcxx-commits, ldionne. Similarly to https://reviews.llvm.org/rL350972 this revision changes std::tuple_element from class to struct. Fixes PR#41331. Repository: rCXX libc++ https://reviews.llv