[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

2019-03-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL357369: gn build: Add build files for most clang-tools-extra unit tests (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60038?vs=192995&id=193019#toc Repository:

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

2019-03-31 Thread Nico Weber via Phabricator via cfe-commits
thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 + +unittest("ClangApplyReplacementsTests") { + configs += [ "//llvm/utils/gn/build:clang_code" ] --

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

2019-03-31 Thread Mirko Bonadei via Phabricator via cfe-commits
mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a small style comment. Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 + +unittest("ClangApplyReplacements

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

2019-03-30 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, ioeric, mgorny, srhines. Herald added a project: LLVM. https://reviews.llvm.org/D60038 Files: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt llvm/utils/gn