This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL357186: Disable warnings when indexing as a standalone
action. (authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: l
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/IndexAction.cpp:138
CI.getLangOpts().CommentOpts.ParseAllComments = true;
+// Index the whole file even if there are warnings and -Werro
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clangd/index/IndexAction.cpp:140
+// Avoids some analyses too.
+CI.getDiagnosticOpts().IgnoreWarnings = true;
return WrapperFrontendAction::BeginInvocation(CI);
sammccall updated this revision to Diff 192651.
sammccall added a comment.
fix baseline
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59935/new/
https://reviews.llvm.org/D59935
Files:
clangd/index/IndexAction.cpp
unittests/clangd/IndexActionTes
sammccall updated this revision to Diff 192650.
sammccall added a comment.
Herald added a subscriber: jdoerfert.
Add tests, fix setting the flag too late.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59935/new/
https://reviews.llvm.org/D59935
File
hokein added inline comments.
Comment at: clangd/index/IndexAction.cpp:140
+// Avoids some analyses too.
+CI.getDiagnosticOpts().IgnoreWarnings = true;
return WrapperFrontendAction::BeginInvocation(CI);
Can we add a unittest for this?
IIRC, `IgnoreW
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
Herald added a project: clang.
- we don't record the warnings at all
- even when -Werror is set, we don't want to stop indexing for a war
