[PATCH] D59900: [Sema] Fix a crash when nonnull checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL357236: [Sema] Fix a crash when nonnull checking (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

hliao added a comment. just search bugzilla and, fortunately, found this issue is reported 2+ years ago @ https://bugs.llvm.org/show_bug.cgi?id=30559. I will revise the test case to PR30559 and move it into test/SemaCXX/nonnull.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

tra added inline comments. Comment at: clang/test/SemaTemplate/decltype.cpp:1 +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// no crash & no diag Rakete wrote: > test/SemaCXX/nonnull.cpp would be a better place to put this test. `test/SemaCXX/nonnu

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

Rakete accepted this revision. Rakete added a comment. This revision is now accepted and ready to land. Otherwise LGTM. Comment at: clang/test/SemaTemplate/decltype.cpp:1 +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// no crash & no diag tes

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

hliao added a comment. just explain what's the issue is and hope that help reviewers to get this fix quick. - In `Sema::DiagnoseAlwaysNonNullPointer`, we issue warnings if a `nonnull` parameter is used in null checking. It need the function declaration to check parameter attributes. That usual

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

jlebar added a comment. I uh... I also think this is an @rsmith question, I have no idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59900/new/ https://reviews.llvm.org/D59900 ___ cfe-commits maili

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

tra added subscribers: jlebar, rsmith. tra added a comment. @rsmith, @jlebar I'm out of my depth here and could use some language lawyering help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59900/new/ https://reviews.llvm.org/D59900 _

[PATCH] D59900: [Sema] Fix a crash when nonnull checking

hliao created this revision. hliao added reviewers: rjmccall, tra, yaxunl. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Non-null checking is triggered during prototype substitution from a template instantiation, if expressions in `decltype` c