[PATCH] D59899: gn build: Add some build files for clangd

2019-03-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL357182: gn build: Add some build files for clangd (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59899?vs=192509&id=192663#toc Repository: rL LLVM CHANGES SINC

[PATCH] D59899: gn build: Add some build files for clangd

2019-03-28 Thread Nico Weber via Phabricator via cfe-commits
thakis marked 2 inline comments as done. thakis added a comment. Thanks! Landing with comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59899/new/ https://reviews.llvm.org/D59899 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D59899: gn build: Add some build files for clangd

2019-03-28 Thread Mirko Bonadei via Phabricator via cfe-commits
mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. Sorry for the delay, LGTM % 2 small comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-apply-replacements/BUILD.gn:2 static_library("clang-apply-repl

[PATCH] D59899: gn build: Add some build files for clangd

2019-03-27 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, jfb, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, srhines. Herald added a project: LLVM. Enough to build the clangd binaries, but this is still missing build files for: -