This revision was automatically updated to reflect the committed changes.
Closed by commit rC361261: [ARM][CMSE] Add commandline option and feature macro
(authored by javed.absar, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59879/new/
https://rev
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
LGTM. With one comment that I will leave to you for what you think is best.
Comment at: include/clang/Driver/Options.td:2145
+ Flags<[DriverOption,CC1Option]>,
+ HelpText
javed.absar updated this revision to Diff 199819.
javed.absar added a comment.
Updated based on review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59879/new/
https://reviews.llvm.org/D59879
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticCommonKinds.td
javed.absar marked 4 inline comments as done.
javed.absar added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:438
+} else if (Feature == "+8msecext") {
+ if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+Diags.Report(diag::err_target_u
snidertm added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:438
+} else if (Feature == "+8msecext") {
+ if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+Diags.Report(diag::err_target_unsupported_mcmse) << CPU;
dmgree
dmgreen added reviewers: olista01, christof.
dmgreen added inline comments.
Comment at: include/clang/Driver/Options.td:2145
+ Flags<[DriverOption,CC1Option]>,
+ HelpText<"Allow use of CMSE instructions (ARM only)">;
Should this say something about compiling
snidertm added inline comments.
Comment at: lib/Basic/Targets/ARM.cpp:438
+} else if (Feature == "+8msecext") {
+ if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+Diags.Report(diag::err_target_unsupported_mcmse) << CPU;
How do
javed.absar created this revision.
javed.absar added a reviewer: dmgreen.
Herald added a subscriber: kristof.beyls.
Herald added a project: clang.
This is first in series of patches following the RFC
http://lists.llvm.org/pipermail/cfe-dev/2019-March/061834.html informing the
community about pro
