This revision was automatically updated to reflect the committed changes.
Closed by commit rL357162: [PR41247] Fixed parsing of private keyword in C++.
(authored by stulova, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
Anastasia updated this revision to Diff 192485.
Anastasia added a comment.
Herald added a subscriber: jdoerfert.
Extended test case and explained the intention of the test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59874/new/
https://reviews.llvm.org/D59874
Files:
lib/Parse/Parse
rjmccall added a comment.
Otherwise LGTM.
Comment at: test/SemaOpenCLCXX/private-access-specifier.cpp:2
+// RUN: %clang_cc1 %s -pedantic -verify -fsyntax-only
+
+struct B {
Please include a comment explaining why this test file is in
test/SemaOpenCLCXX/ (becau
Anastasia created this revision.
Anastasia added reviewers: rjmccall, jsji.
Herald added a subscriber: ebevhan.
In C++ `private` shouldn't be parsed as a valid address space keyword.
This only fixes C++ part, in OpenCL we should still prevent ICE on the reported
code example, but I will fix it s
