[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-28 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL357184: [CodeGen] Add additional mangling for struct members of non trivial structs (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-28 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Looks good. I'll commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-28 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm added a comment. @smeenai good idea on the third level! Yep, I'll need somebody to commit this for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-28 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm updated this revision to Diff 192652. danzimm added a comment. Add a third level to ensure nontrivial structs within structs within structs works (this suggests that N embeddings works too). Also change the invocation of the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Also, it might be worth adding a third level of struct to the test, to show that it handles arbitrary nesting correctly (which it does). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Do you need someone to commit this for you? Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-within-struct-name.m:1 +// RUN: %clang_cc1 -triple arm64-apple-ios11 -fobjc-arc -fblocks -fobjc-runtime=ios-11.0 -emit-llvm -o - -DUSESTRUCT -I %S/Input

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm added a comment. @smeenai please feel free add any reviewers that I might've missed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___ cfe-commits mail

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm updated this revision to Diff 192436. danzimm added a comment. I forgot to add the test originally, this update contains a test and updates to old tests to make them pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://rev

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm added a comment. @lebedev.ri right, sorry about that- I prematurely diff'd (got a few terminals crossed and thought I was finished with the test already). I will be amending with a test and a few other test fixes shortly. Sorry about the miscommunication :/ Repository: rG LLVM Githu

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. There is no test here. Tests should probably go into `clang/test/CodeGen`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___ cfe-c

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

2019-03-27 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://bugs.llvm.org/show_bug.cgi?id=41206 we observe bad codegen when embedding a non-trivial C struct within a C struct. This is due to the fact that name mangling for non-trivial structs