arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: wdng.
This should not be a new device name. This is also not how the features should
be passed to the backend. These should be added to the function IR dire
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Basic/Cuda.cpp:113
+ case CudaArch::GFX906_SRAM_ECC: // TBA
+return "gfx906+sram-ecc";
case CudaArch::GFX909: // TBA
tra wrote:
> Wording nit:
> Does it mean `+(SRAM, E
tra added inline comments.
Comment at: lib/Basic/Cuda.cpp:113
+ case CudaArch::GFX906_SRAM_ECC: // TBA
+return "gfx906+sram-ecc";
case CudaArch::GFX909: // TBA
Wording nit:
Does it mean `+(SRAM, ECC)` or `+SRAM, -ECC` ?
From the rest of the changes I gue
yaxunl created this revision.
yaxunl added reviewers: tra, ashi1.
Herald added a subscriber: jholewinski.
Add a new gpu arch gfx906+sram-ecc for HIP.
It is similar to gfx906 but implies target feature sram-ecc enabled,
whereas gfx906 implies target sram-ecc disabled. Corresponding
option -mattr=[
