[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

This revision was automatically updated to reflect the committed changes. Closed by commit rL359179: [Testing] Move clangd::Annotations to llvm testing support (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59814?vs=196599&id=196602#toc Repository:

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196599. ilya-biryukov added a comment. - Added a death test for error conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814 Files: clang-tools-extra/unitte

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

sammccall accepted this revision. sammccall added inline comments. Comment at: llvm/lib/Testing/Support/Annotations.cpp:94 +const llvm::Annotations::Range &R) { + return O << llvm::formatv("[{0}, {1})", R.Begin, R.End); +} You

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196592. ilya-biryukov added a comment. - Add simple tests - Add equality and stream output operators for Range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814 Fil

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov added a comment. I've added a FIXME to the class. Also want to add some basic tests before landing this. Comment at: clang-tools-extra/unittests/clangd/Annotations.h:8 //===--===// -// -// Annot

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 192673. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Move Range into the body of Annotations - Use triple-slash comments - Added a FIXME that we might want to change the syntax - Move the doc comment to the class Rep

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Testing/Support/Annotations.h:9 // // Annotations lets you mark points and ranges inside source code, for tests: // ---

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

sammccall added a comment. This probably needs tests if we're lifting it into `llvm`. Sorry there aren't any today :-( BTW the other similar lib in clang I'm aware of is https://reviews.llvm.org/diffusion/L/browse/cfe/trunk/tools/clang-refactor/TestSupport.h It makes different tradeoffs. We ta

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Seeking feedback for this change, mostly interested if this a good place for test helpers like this? I'm planning to author more tests in `clangTooling` using this soon, so moving it somewhere clang-specific is an opt

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, hiraditya, mgorny. Herald added projects: clang, LLVM. Annotations allow writing nice-looking unit test code when one nee