[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

2019-03-23 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. Hi @phosek ! Fixed in rL356847 . This did make me look a little deeper into this issue though, and wonder if the CLANG_DEFAULT_LINKER is implemented in a useful way right now. I believe the reason this came up for you guys in that you

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

2019-03-23 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. This broke our builders (see https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8918246038501974992/+/steps/clang/0/steps/test/0/stdout) because the test uses the default linker (lld in our case) instead of `wasm-ld`, it seems that the `clang`

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

2019-03-22 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356817: [WebAssembly] Make driver -pthread imply linker --shared-memory (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

2019-03-22 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: sbc100, aheejin. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, dschuff. Herald added a project: clang. This eliminates a linker error the user might otherwise see about how using the 'atomics' feature requires --share